Space-time tomography for continuously deforming objects

SIGGRAPH 2018


Reviews

Information

  • Paper topic: Animation and Simulation
  • Software type: Code
  • Able to run a replicability test: False
  • Replicability score: 1
  • Software language: C/C++
  • License: Creative Commons
  • Build mechanism: None
  • Dependencies: argtable/eigen/cimg/glut/glew/libtiff
  • Documentation score {0,1,2}: 1
  • Reviewer: Nicolas Bonneel <nicolas.bonneel@liris.cnrs.fr>
  • Time spent for the test (build->first run, timeout at 100min): 60min

Source code information

Comments

There are multiple issues with the code. While no makefile is provided, it is relatively easy (though cumbersome because of several dependencies) to create a Visual Studio 2017 project. Not listed as a dependency is libtiff.
In main.cpp, due to issues with "goto", you need to move the declarations of data (line 142), proNo (line 148), scene (line 149), mainWindow (line 154) at the begining of the main. It should look like:
	VolumeData* data = new VolumeData;
	GLUTSceneContainer *mainWindow;
	int proNo;
	ST_Tomography *scene;
around line 49.
In ST_Tomography.cpp, strdup (line 188) should be replaced by _strdup because it is deprecated in Visual Studio 2017 (it produces a compilation error although the code is supposed to compile with Visual Studio 2015 and 2018 according to the Readme).
But then multiple files seems missing, and could either not be found on the internet (a "linear_solver.h" that contains a "linear_solver" namespace, a "scope.h" that includes a #define called "utilities_scope_defines", a file called "image_blas.h" that performs blas-like operations on images), or a generic and could be recoded (e.g., "vec3.h"). Similarly, "str_format" is not a standard function in Visual Studio, so I am not sure where it is supposed to come from.
Ultimately, I could not compile the code.

--alternative test on linux--
Unable to compile, had to create a CMakeLists (no build instruction), several bugfix needed: goto crosses initialization issues, includes missing (cstring) missing linear_solver.h file ...

If you want to contribute with another review, please follow these instructions.

Please consider to cut/paste/edit the raw JSON data attached to this paper.