Water surface wavelets

SIGGRAPH 2018


Reviews

Information

  • Paper topic: Animation and Simulation
  • Software type: Code
  • Able to run a replicability test: False
  • Replicability score: 0
  • Software language: C++
  • License: MIT License
  • Build mechanism: cmake,vcpkg
  • Dependencies: magnum (installed using VCPKG)
  • Documentation score {0,1,2}: 1
  • Reviewer: David Coeurjolly <david.coeurjolly@liris.cnrs.fr>
  • Time spent for the test (build->first run, timeout at 100min): 30min

Source code information

Comments

The build instructions are pretty simple. I just need to update a bit the vcpkg command to install magnum:
 ./vcpkg install "magnum-integration[imgui]"
 instead of
./vcpkg install magnum-integration[imgui].

 The project cmake worked fine but I had a first issue with Eigen (installed using brew on mac). Adding a 

 #include_directories("/usr/local/include")

 in the CmakeLists.txt sovled the problem.
 A second issue was for a missing KHR/hhrplatform.h file. Downloading the file as mentionned here (https://stackoverflow.com/questions/50656174/error-when-building-with-mingw-on-ubtunu) solved the problem. Finally, the build succeeded but the runtime failed:

Platform::Sdl2Application: warning: the executable is not a HiDPI-enabled app bundle
Renderer: AMD Radeon HD - FirePro D500 OpenGL Engine by ATI Technologies Inc.
OpenGL version: 4.1 ATI-3.8.24
Using optional features:
    GL_ARB_ES2_compatibility
    GL_ARB_separate_shader_objects
    GL_ARB_texture_filter_anisotropic
    GL_ARB_texture_storage
    GL_ARB_vertex_array_object
    GL_EXT_debug_label
    GL_EXT_debug_marker
Using driver workarounds:
    no-layout-qualifiers-on-old-glsl
Shader::compile(): compilation of vertex shader 1 failed with the following message:
ERROR: 3:18: '' : syntax error: incorrect preprocessor directive
ERROR: 3:18: '' : syntax error: unexpected tokens following #if preprocessor directive - expected a newline
Shader::compile(): compilation of fragment shader 2 failed with the following message:
ERROR: 3:8: '' : syntax error: incorrect preprocessor directive
ERROR: 3:8: '' : syntax error: unexpected tokens following #if preprocessor directive - expected a newline
Assertion GL::Shader::compile({vert, frag}) failed in /tmp/WaterSurfaceWavelets/src/visualization/waterSurface/WaterSurfaceShader.cpp on line 29

Misc. comments

The project page also contains a windows executable if was not able to run on mac

Information

  • Paper topic: Animation and Simulation
  • Software type: Code
  • Able to run a replicability test: True
  • Replicability score: 2
  • Software language: C++
  • License: MIT License
  • Build mechanism: cmake,vcpkg
  • Dependencies: magnum (installed using VCPKG)
  • Documentation score {0,1,2}: 1
  • Reviewer: Julie Digne <julie.digne@liris.cnrs.fr>
  • Time spent for the test (build->first run, timeout at 100min): 20min

Source code information

Comments

The compilation worked out-of-the-box following the readme instructions. However the Demo did not produce the expected result. The water and land appear but the waves seem to appear at a different rendering depth, and be decorrelated with the water/land distribution. Hence I was not able to reproduce the results (Ubuntu 18.04 - GeForce GTX 1050)

If you want to contribute with another review, please follow these instructions.

Please consider to cut/paste/edit the raw JSON data attached to this paper.