Navigating intrinsic triangulations

SIGGRAPH 2019


Reviews

Information

  • Paper topic: Geometry
  • Software type: Code
  • Able to run a replicability test: True
  • Replicability score: 5
  • Software language: c++
  • License: MIT
  • Build mechanism: cmake
  • Dependencies: geometry-central,polyscope,glfw,eigen
  • Documentation score {0,1,2}: 2
  • Reviewer: David Coeurjolly <david.coeurjolly@liris.cnrs.fr>
  • Time spent for the test (build->first run, timeout at 100min): 10min

Source code information

Comments

The main code is available in the geometry-central library. The provided code in the project page is a demo code with graphical and CLI interface to the intrinsic triangulation. The cmake script installs all dependencies in a very convenient way. No issue to build the project.
On Mac, there is an issue when building geometry-central:

 make[2]: *** No rule to make target `../deps/geometry-central/deps/-lm', needed by `bin/int_tri'.  Stop.

 Note that this bug has been fixed in the geometry-central master (not the same version as the git submodule in the deps folder).
To fix the issue, just upgrade the submodule to the master:

 cd deps/geometry-central/ ; git checkout master ; cd ../../build ; make

Beside this issue, most paper results can be reproduced from the code.

If you want to contribute with another review, please follow these instructions.

Please consider to cut/paste/edit the raw JSON data attached to this paper.