Progressive embedding

SIGGRAPH 2019


Reviews

Information

  • Paper topic: Geometry
  • Software type: Code
  • Able to run a replicability test: True
  • Replicability score: 4
  • Software language: C++
  • License: Mozilla Public License 2.0
  • Build mechanism: cmake
  • Dependencies: libIGL (custom fork), CGAL, TRIANGLE, OpenGL, TBB
  • Documentation score {0,1,2}: 1
  • Reviewer: David Coeurjolly <david.coeurjolly@liris.cnrs.fr>
  • Time spent for the test (build->first run, timeout at 100min): 30min

Source code information

Comments

To compile the code, you need a special branch of libigl. This is mentioned in the README.md. Make sure to follow the instructions AFTER having cloned the Progressive Embedding project:
  git clone https://github.com/hankstag/progressive_embedding.git
  cd progressive_embedding
then the then libigl cloning instructions.
The CMakeLists has several issues. First, a source file is missing (test_local_smoothing.cpp), so you would need to comment out the line 91 and 101 of the CMakeLists.txt. Then, there is a tbb link issue: line 93
   target_link_libraries(progressive_embedding igl::core igl::triangle igl::opengl_glfw igl::cgal igl::opengl_glfw_imgui tab_static)
must be replaced by
   target_link_libraries(progressive_embedding igl::core igl::triangle igl::opengl_glfw igl::cgal igl::opengl_glfw_imgui tbb_static)

 After that, everything builds perfectly. There is no precise description nor documentation of the executables but using the provided data and the given examples, I was able to reproduce some results that seem to match with the paper ones.

Misc. comments

The authors provide all the result data of their paper (google drive link: https://drive.google.com/file/d/1caGIzPd9trlx0EvBbE06S2L3g1kHvIwJ/view?usp=sharing, 1.4Go (ZIP)).

If you want to contribute with another review, please follow these instructions.

Please consider to cut/paste/edit the raw JSON data attached to this paper.